Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlx Cli: Added force flag to drop database for postgres #2873

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Sqlx Cli: Added force flag to drop database for postgres #2873

merged 11 commits into from
Nov 21, 2023

Conversation

Vrajs16
Copy link
Contributor

@Vrajs16 Vrajs16 commented Nov 10, 2023

This pull request will let users use the -f flag to drop the database if there are active connections

close #2075, close #2867

abonander
abonander requested changes Nov 15, 2023
View reviewed changes
sqlx-core/src/migrate/migrate.rs Outdated Show resolved Hide resolved
@Vrajs16 Vrajs16 marked this pull request as draft November 16, 2023 20:07
@Vrajs16 Vrajs16 marked this pull request as ready for review November 16, 2023 20:42
@Vrajs16 Vrajs16 requested a review from abonander November 16, 2023 20:42
abonander
abonander approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Can you fix the merge conflict?

@abonander abonander merged commit fda4159 into launchbadge:main Nov 21, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonander abonander abonander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Vrajs16 @abonander